Merge2025 #28
Merged
Merge2025 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls, unlock layer UI
There was a problem hiding this comment.
Copilot reviewed 11 out of 15 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- visualize/templates/visualize/bookmark-modals.html: Language not supported
- visualize/templates/visualize/embedded.html: Language not supported
- visualize/templates/visualize/modals.html: Language not supported
- visualize/templates/visualize/planner.html: Language not supported
Remove debugger statement Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pollardld
commented
Apr 10, 2025
| return true; | ||
| } | ||
| return false; | ||
| // if (!self.isVisibleAtZoom() || self.isLocked()) { |
Member
Author
There was a problem hiding this comment.
If no longer needed, please delete commented out code
| // example use: saveStateMode will be false when a user is viewing a bookmark | ||
| app.saveStateMode = true; | ||
|
|
||
| window.app = app; |
Member
Author
There was a problem hiding this comment.
I am curious to learn the reason for assigning app to window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portal Sync - Merge 2025
This pull request includes several updates to the
visualizeapplication, focusing on database migrations, JavaScript functions for managing bookmarks and layers, and adding new functionalities to the map and theme models. The most important changes include altering database fields for bookmarks and user layers, updating URL shortening logic, and adding new event listeners for layer and theme interactions.Database Migrations:
bookmarkanduserlayermodels to improve handling of content types, sharing groups, and user relationships. (visualize/migrations/0012_alter_bookmark_content_type_and_more.py)visualize/migrations/0013_merge_20240411_2135.py)JavaScript Updates:
bookmarksModelto handle URL shortening more robustly, including CSRF token integration and error handling. (visualize/static/js/bookmarks.js) [1] [2]layerModelto include new properties, improve visibility logic, and add event dispatching for layer activation and deactivation. (visualize/static/js/models.js) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]visualize/static/js/models.js) [1] [2] [3] [4]Map Enhancements:
addLayerToMapfunction to support new layer types, includingslider. (visualize/static/js/map.js)These changes collectively enhance the functionality and maintainability of the
visualizeapplication, ensuring better data management and user interaction handling.