#32 slider widget fails #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… render slider widget in Chrome on Windows
…dgets are not loading from shortened URL links
…d Chrome loading glitch on Windows
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the slider widget failure by introducing a timeout before layer activation to ensure that parent elements exist.
- Adds a 200ms timeout in state.js to delay layer activation.
- Improves error handling in models.js with extra conditions and a simplified slider redraw call.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| visualize/static/js/state.js | Wraps layer activation in a setTimeout to fix widget initialization. |
| visualize/static/js/models.js | Adds an extra condition to avoid errors and simplifies slider redraw logic. |
… would likely fail for hashes with multiple layers
…drawSlider to maintain execution context
There was a problem hiding this comment.
Pull Request Overview
This PR fixes timing issues when restoring layers from the URL hash by delaying slider initialization, and tightens lookup guards and event binding logic in the layer model.
- Adds a 200 ms timeout before activating hash state layers to ensure DOM readiness.
- Adds an existence check for multilayerValueLookup entries and refactors slider callbacks.
- Adjusts the animate-slider event binding condition to only bind once.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| visualize/static/js/state.js | Wraps activateHashStateLayers loop in a 200 ms setTimeout. |
| visualize/static/js/models.js | Guards against undefined lookup, binds drawSlider, updates .length check. |
Copilot caught my off-by-one error. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32 -- adds a timeout before loading layers from hash. For Chrome on Windows, this was trying to build slider widgets before the parent elements were created.