Skip to content

Conversation

@JP0P
Copy link
Collaborator

@JP0P JP0P commented Dec 19, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Stabilizes Maestro E2E tests by adding waits/retries, refining selectors and flows, and adjusting steps across account, wallet, notification, and relogin scenarios.

  • Accounts / Light Account (maestro/01-accounts/C000006-light-account.yaml)

    • Replace several assertVisible checks with extendedWaitUntil, increase timeouts, and add Web3/Discover modal handling.
    • Add receive-screen checks via Deposit, prevent key access via long-press, and insert relogin via shared PIN flow.
    • Dismiss keychain prompt on credential login and ensure Assets visibility.
  • Wallets

    • C000033-pause-wallets.yaml: Gate transient toast assertion to iOS; keep pause verification and save-state wait.
    • C000037-split-wallets.yaml: Re-enable ETH balance verification with longer wait (60s).
    • C000044-create-all-wallet-types.yaml: Create account with only Bitcoin to speed sync; slow scroll speed for wallet verification.
    • C000045-add-edit-tokens.yaml: Target ETH wallet directly (no WALLET_NAME), navigate via long-press on ETH, and keep token add/validate flow.
    • C000048-split-all-evm.yaml: Update expected EVM list ordering; add retry-based scrolling/tap with lower speed and longer post-split wait.
  • Notifications (maestro/12-notifications/C000015-ip-validation-reminder.yaml)

    • Assert by element id, dismiss modals, and reduce relaunch cycles (10→5) while ensuring card does not reappear.
  • Common (maestro/common/relogin-pin.yaml)

    • Switch to launchApp + wait for Exit PIN before PIN taps to standardize relogin.

Written by Cursor Bugbot for commit f494a7e. This will update automatically on new commits. Configure here.


@JP0P JP0P force-pushed the jared/fix-cross-device-tests branch 3 times, most recently from 915e9b2 to 2232350 Compare December 19, 2025 22:21
@JP0P JP0P force-pushed the jared/fix-cross-device-tests branch 3 times, most recently from ed4ee90 to 9fa5ce1 Compare December 19, 2025 22:47
@JP0P JP0P force-pushed the jared/fix-cross-device-tests branch from 9fa5ce1 to f494a7e Compare December 20, 2025 02:43
@JP0P JP0P merged commit 63cfb32 into develop Dec 20, 2025
4 checks passed
@JP0P JP0P deleted the jared/fix-cross-device-tests branch December 20, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants