Skip to content

redesign gmae page #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ingoau merged 3 commits into from
Jun 15, 2025
Merged

redesign gmae page #372

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9218650
redesign gmae page
ingoau Jun 15, 2025
6b49a78
Add rel attrib
ingoau Jun 15, 2025
36ac412
Prettified Code!
Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 26 additions & 20 deletions src/lib/components/play.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,28 +60,34 @@
});
</script>

<div class="flex h-full w-full flex-row gap-3 p-3">
<iframe src={gmaedata?.url} frameborder="0" class="flex-grow rounded" title={gmaedata?.name}
></iframe>
<div class="flex h-full w-full flex-col gap-3 p-3">
<iframe src={gmaedata?.url} frameborder="0" class="grow rounded" title={gmaedata?.name}></iframe>
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add basic security & performance attributes to the <iframe>

The iframe is rendered without loading="lazy" (helps first-paint) and without any sandbox/allow attributes (mitigates XSS / click-jacking if an attacker ever controls the url). At minimum consider:

-	<iframe src={gmaedata?.url} frameborder="0" class="grow rounded" title={gmaedata?.name}></iframe>
+	<iframe
+		src={gmaedata?.url}
+		frameborder="0"
+		loading="lazy"
+		allow="fullscreen"
+		sandbox="allow-scripts allow-same-origin"
+		class="grow rounded"
+		title={gmaedata?.name}
+	></iframe>

sandbox can be relaxed/strengthened depending on what the embedded site requires.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<iframe src={gmaedata?.url} frameborder="0" class="grow rounded" title={gmaedata?.name}></iframe>
<iframe
src={gmaedata?.url}
frameborder="0"
loading="lazy"
allow="fullscreen"
sandbox="allow-scripts allow-same-origin"
class="grow rounded"
title={gmaedata?.name}
></iframe>
🤖 Prompt for AI Agents 
In src/lib/components/play.svelte at line 64, the iframe lacks security and
performance attributes. Add loading="lazy" to defer loading for better
performance, and include a sandbox attribute with appropriate restrictions to
mitigate XSS and click-jacking risks. Adjust the sandbox permissions based on
the embedded content's needs to balance security and functionality.

Copy link
Member Author

@ingoau ingoau Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai I don't want it sandboxed

Copy link
Member Author

@ingoau ingoau Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro just sends eyes emoji

Copy link
Contributor

@coderabbitai coderabbitai bot Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inglan Got it! Since you don't want sandboxing, here's a lighter version with just the performance and functionality improvements:

<iframe
	src={gmaedata?.url}
	frameborder="0"
	loading="lazy"
	allow="fullscreen"
	class="grow rounded"
	title={gmaedata?.name}
></iframe>

The loading="lazy" helps with page performance, and allow="fullscreen" ensures the fullscreen button works properly with the iframe content. No security restrictions that might interfere with the games.

🐰
ears perk up attentively

✏️ Learnings added 
Learnt from: Inglan
PR: EducationalTools/src#372
File: src/lib/components/play.svelte:64-64
Timestamp: 2025-06-15T06:50:30.068Z
Learning: User Inglan prefers not to use sandbox attributes on iframes in the EducationalTools/src project, as they don't want the embedded content to be sandboxed.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

Copy link
Contributor

@coderabbitai coderabbitai bot Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inglan Understood! Here's a modified suggestion without the sandbox attribute, keeping just the performance and basic functionality improvements:

<iframe
	src={gmaedata?.url}
	frameborder="0"
	loading="lazy"
	allow="fullscreen"
	class="grow rounded"
	title={gmaedata?.name}
></iframe>

The loading="lazy" will still help with performance, and allow="fullscreen" ensures the fullscreen functionality works properly when users click the fullscreen button.

✏️ Learnings added 
Learnt from: Inglan
PR: EducationalTools/src#372
File: src/lib/components/play.svelte:64-64
Timestamp: 2025-06-15T06:51:40.887Z
Learning: In the EducationalTools/src project, the user prefers not to use iframe sandbox attributes when loading game content, likely to avoid restricting game functionality.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


<div class="flex h-full w-72 flex-col gap-2">
<a href="/" class={clsx(badgeVariants({ variant: 'secondary' }), 'w-fit')}
>{gmaedata?.category}<ArrowRight class="ml-1 size-3" /></a
>
<h1 class="text-4xl font-bold">{gmaedata?.name}</h1>
<div class="flex w-full flex-row flex-wrap gap-2">
{#each gmaedata?.tags || [] as tag}
<Badge variant="default">#{tag}</Badge>
{/each}
{#each gmaedata?.links || [] as link}
<a href={link.url} target="_blank" class={badgeVariants({ variant: 'outline' })}>
<OpenInNewTab class="mr-1 size-3" />{link.name}
</a>
{/each}
<div class="flex w-full flex-col gap-2 md:flex-row">
<div class="flex flex-col gap-2">
<a href="/" class={clsx(badgeVariants({ variant: 'secondary' }), 'w-fit')}
>{gmaedata?.category}<ArrowRight class="ml-1 size-3" /></a
>
<h1 class="text-4xl font-bold">{gmaedata?.name}</h1>
<div class="flex w-full flex-row flex-wrap gap-2">
{#each gmaedata?.tags || [] as tag}
<Badge variant="default">#{tag}</Badge>
{/each}
{#each gmaedata?.links || [] as link}
<a
href={link.url}
target="_blank"
rel="noopener noreferrer"
class={badgeVariants({ variant: 'outline' })}
>
<OpenInNewTab class="mr-1 size-3" />{link.name}
</a>
{/each}
</div>
<p class="text-xl">{gmaedata?.description}</p>
</div>
<p class="text-xl">{gmaedata?.description}</p>
<div class="flex-grow"></div>
<div class="flex flex-col gap-3">
<div class="grow"></div>
<div class="flex min-w-72 flex-col gap-3">
<Drawer.Root direction="right">
<Drawer.Trigger class={buttonVariants({ variant: 'outline' })}>
<Comment class="h-6 w-6" />
Expand Down