Document fromReadableStream method of Streams#1286
Open
tmcw wants to merge 2 commits intoEffect-TS:mainfrom
Open
Document fromReadableStream method of Streams#1286tmcw wants to merge 2 commits intoEffect-TS:mainfrom
tmcw wants to merge 2 commits intoEffect-TS:mainfrom
Conversation
|
@tmcw is attempting to deploy a commit to the Effect Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
I'd also like to document:
Proposed code example for Node.js interop: import { Effect, Stream } from "effect"
import { Readable } from "node:stream";
const exampleStream = Readable.from(['Hello', 'world'])
const stream = Stream.fromAsyncIterable(
exampleStream,
(e) => new Error(String(e)) // Error Handling
)
Effect.runPromise(Stream.runCollect(stream)).then(console.log)
// { _id: 'Chunk', values: [ 1, 2 ] } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Per the referenced document, Effect has its own Streams construct, which is great. Many people are going to have their own streams from other platforms - mostly web streams and Node streams. There are ways to interoperate between these kinds of streams, but the documentation does not hint at what they are. This adds the first bit of documentation that tells how to interoperate, specifically how to create a Stream from a ReadableStream.
Related
cc @gcanti for review