Docs: Update example in cause.mdx to be a little more illustrative#1296
Open
jsfeldman wants to merge 1 commit intoEffect-TS:mainfrom
Open
Docs: Update example in cause.mdx to be a little more illustrative#1296jsfeldman wants to merge 1 commit intoEffect-TS:mainfrom
jsfeldman wants to merge 1 commit intoEffect-TS:mainfrom
Conversation
I feel like calling the Effect.all function with `{ concurrentcy: "unbounded" }` represents the usefulness of the Cause.failures and Cause.defects functions a little clearer than the existing version without it being set to unbounded.
Then again, the existing version made me think for a bit so maybe that's useful in its own right.
|
@jsfeldman is attempting to deploy a commit to the Effect Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
I feel like calling the Effect.all function with
{ concurrentcy: "unbounded" }represents the usefulness of the Cause.failures and Cause.defects functions a little clearer than the existing version without it being set to unbounded.Then again, the existing version made me think for a bit so maybe that's useful in its own right and intentional.
Related