Update to use new manifest format in Vite 2.0.0-beta.51#8
Merged
Conversation
…ty chunks are replaced with their asset
… and empty chunks are replaced with their asset" This reverts commit f6f2d05.
ElMassimo
commented
Jan 29, 2021
| def resolve_references(manifest) | ||
| manifest.each_value do |entry| | ||
| entry['file'] = prefix_vite_asset(entry['file']) | ||
| entry['css'] = Array.wrap(entry['css']).map { |path| prefix_vite_asset(path) } if entry['css'] |
Owner
Author
There was a problem hiding this comment.
Wrapping the array ensures compatibility with beta 51.
ElMassimo
commented
Jan 29, 2021
| when :javascript then 'js' | ||
| when :stylesheet then 'css' | ||
| when :typescript then dev_server_running? ? 'ts' : 'js' | ||
| when :typescript then 'ts' |
Owner
Author
There was a problem hiding this comment.
Vite now uses the actual file extension in the manifest, so we can simplify here.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request adds support for Vite 2.0.0-beta.51 and higher (tested on 56).
It adds a new plugin to generate a
manifest-assets.jsonfile in the output for any CSS or asset entrypoints.No changes to the public-facing API of this library 😎
Background 📜
There are breaking changes to the manifest format in beta.51 and beta.53, that required updating the way the manifest is parsed.
Those changes also required adding a plugin to generate a separate manifest for assets, since Vite's manifest now assumes all entries are JS or HTML.
Screenshots 📷