Lookup table mont #265
Merged
Lookup table mont #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMaier-IRT
requested review from
SteveMaier-IRT and
keithrfung
and removed request for
SteveMaier-IRT
…rd-cpp into lookup_table_mont
AddressXception
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Link your PR to an issue
Fixes #254
Description
In order to add code to make the Lookup_Table store table entries in Montgomery form (Issue 253) we need Hacl code to support converting to/from Montgomery form. We also need the Hacl functions to perform multiply with modular reduction. The code in this PR comes from the gcc-compatible repo of the Hacl-star project. Changes have been made to the Hacl_GenericField64.c to lock it into 4096 bit big numbers in order to get it to compile in our environment.
Testing
No testing has been added. At this point no code will be using this code, however, this is low level code that will be used by any ballot encryption and will enventually be covered by lots of other tests.