A plus bc mod q redo #274
Merged
A plus bc mod q redo #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Link your PR to an issue
Fixes #270
Description
This a change to the a_plus_bc_mod_q function. The function was using 4096 bit math functions from the HACL package but it is only working on 256 bit numbers. The change is to use the 256 bit math functions from the HACL package. This function is used twice for each Chaum Pedersen proof so speeding this up, will likelly make a difference to overall performance.
Testing
This code is low level code that is used many times during a ballot encryption so no additional testing was added. A benchmark for this function was added however.