Adds an -fno-stack-check compile time flag to OSX local builds #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK, makes sense to me. |
Member
|
In light of this we could probably remove the same flag in ci/test/00_setup_env_mac_host.sh, which fixes this for CI? |
gwillen
pushed a commit
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a workaround for several elements issues on OSX 10.15 and later, this PR adds the
-fno-stack-checkflag to local (non-cross compile) OSX builds.Background: There seems to be a general issue with OSX (version >= 10.15) builds and clang's default use of
-fstack-checkwhich seems to be buggy enough to cause issues with multiple projects.closes #987 #998
Also related to #782