[0.17] Activate CSV from genesis block for custom chains #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
changed the title
instagibbs
force-pushed
the
csv_always
branch
from
2db3e75 to
fba529d
Compare
30 tasks
instagibbs
force-pushed
the
csv_always
branch
from
fba529d to
e67541c
Compare
Contributor
Author
|
Realized that bitcoin_functional run was actually running both suites, causing it to timeout. fixed in fixup commit. |
stevenroose
approved these changes
Feb 13, 2019
Contributor
stevenroose
left a comment
stevenroose
left a comment
There was a problem hiding this comment.
Just some doubt about turning off the tests.
| """Test activation of the first version bits soft fork. | ||
| """Test activation of CSV at genesis for Elements.""" | ||
|
|
||
| This soft fork will activate the following BIPS: |
Contributor
There was a problem hiding this comment.
Is it smart to remove all this instead of disable somehow? I'm not sure, but I think this might make upstream updates harder.
Contributor
Author
There was a problem hiding this comment.
I could remove the test from test_runner, then add a specific check in a custom test?
Contributor
Author
There was a problem hiding this comment.
rather than disable the test, I just reverted all the changes and had the functional suite default to bitcoin-regtest argument
instagibbs
force-pushed
the
csv_always
branch
from
9c5dbc4 to
3774d46
Compare
instagibbs
force-pushed
the
csv_always
branch
from
3774d46 to
91dd327
Compare
Contributor
|
tACK 91dd327 |
stevenroose
added a commit
that referenced
this pull request
Feb 14, 2019
91dd327 Disable functional tests for bitcoin_functional build (Gregory Sanders) b8820d1 Activate CSV from genesis block for custom chains (Gregory Sanders) Pull request description: Guts the test for elements mode, can add back later if worked on. Tree-SHA512: a2b7633fa02dae582616ac26d25cd08f895d5940e3775c70cacdd3f678f01a21cbcaf56c6c540b91bd8535bb1aab7bdc59e2a79b5a1124cbd9d3f03f29d0b40e
Member
|
Does anyone remember the motivation for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guts the test for elements mode, can add back later if worked on.