Peg-in fields for PSBT #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
concept ACK though: fails for the bitcoind parent run because |
Contributor
Author
|
Fixed by sending both |
instagibbs
approved these changes
Dec 3, 2019
| {"sequence", RPCArg::Type::NUM, /* default */ "depends on the value of the 'replaceable' and 'locktime' arguments", "The sequence number"}, | ||
| {"pegin_bitcoin_tx", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The raw bitcoin transaction (in hex) depositing bitcoin to the mainchain_address generated by getpeginaddress"}, | ||
| {"pegin_txout_proof", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "A rawtxoutproof (in hex) generated by the mainchain daemon's `gettxoutproof` containing a proof of only bitcoin_tx"}, | ||
| {"pegin_claim_script", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The witness program generated by getpeginaddress."}, |
Contributor
There was a problem hiding this comment.
it's the script with version byte and witness program, not just witness program
instagibbs
added a commit
that referenced
this pull request
Dec 3, 2019
7cb5f6b Sign PSBTs with peg-in data (Andrew Chow) 73711eb Merge psbt peg-in data (Andrew Chow) 4ad849f Finalize psbt peg-ins (Andrew Chow) b7e3695 Test createpsbt and decodepsbt with peg-ins (Andrew Chow) 8ece8e0 Show peg-in info in decodepsbt (Andrew Chow) 646e76f Be able to create peg-in PSBTs in createpegin (Andrew Chow) b5590b2 Add peg-in PSBT fields (Andrew Chow) Pull request description: Adds peg-in fields for PSBT. `createpsbt` uses the new peg-in raw tx api to allow specifying the peg-in data and then adds it to the psbt. `decodepsbt`, `finalizepsbt` and `walletsignpsbt` are both updated to handle peg-in stuff too. Also tests. `walletcreatefundedpsbt` still does not handle peg-in data. It will require handling external inputs which the wallet does not do. I think it would be best to first implement external inputs in `FundTransaction` upstream before allowing `walletcreatefundedpsbt` to accept peg-ins. Tree-SHA512: 838c2cf0de78b6ad948aaec2932326e2e39b6645c98193c90eedaee7e5cd8ebe3e8ea00e3ba4a67d5f862948195f37aded0e6a08a7c3c20def325d4cabb78ee3
instagibbs
added a commit
that referenced
this pull request
Dec 4, 2019
00eb6c0 Test funding peg-in psbt (Andrew Chow) 1ce74e0 Be able to fund transactions with peg-ins (Andrew Chow) 74c4d37 Tests for fundrawtransaction with external inputs (Andrew Chow) c258746 allow fundtx rpcs to work with external inputs (Andrew Chow) 9486cdf Give a better error when tx size estimation fails (Andrew Chow) 8258aaa Allow Coin Selection be able to take external inputs (Andrew Chow) 698340b Allow CInputCoin to also be constructed with COutPoint and CTxOut (Andrew Chow) Pull request description: Allows `fundrawtransaction` and `walletcreatefundedpsbt` to take transactions with pre-selected peg-in inputs and take them into account when selecting additional inputs to meet the output amounts. As a side effect, those RPCs will also now allow pre-selected non-wallet inputs so long as the correct additional solving data is provided (scripts and pubkeys are needed to estimate the size for transaction fees). Based on #751 Ports bitcoin/bitcoin#17211 with some modification to work with elements outputs and such. Tree-SHA512: 813202adfe2b63780bea01b02975dda393197a489a6c1a9590908ac7252d1d0e5f0984125fbfd1dc271524ddad84dc1778a1e8fa447e61235c7f21c6e6999460
stevenroose
pushed a commit
that referenced
this pull request
Mar 16, 2021
delta1
pushed a commit
to delta1/elements
that referenced
this pull request
Aug 7, 2025
8b6470a gui: disable top bar menu actions during shutdown (furszy) 7066e89 gui: provide wallet controller context to wallet actions (furszy) Pull request description: Small follow-up to ElementsProject#751. Fixes another crash cause during shutdown. Which occurs when the user hovers over the wallets list. Future Note: This surely happen in other places as well, we should re-work the way we connect signals. Register lambas without any precaution can leave dangling pointers. ACKs for top commit: hebasto: ACK 8b6470a, I've tested each commit separately on macOS Sonoma 14.0 (Apple M1). Tree-SHA512: 6fbd1bcd6717a8c1633beb9371463ed22422f929cccf9b791ee292c5364134c501e099329cf77a06b74a84c64c1c3d22539199ec49ccd74b3950036316c0dab3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds peg-in fields for PSBT.
createpsbtuses the new peg-in raw tx api to allow specifying the peg-in data and then adds it to the psbt.decodepsbt,finalizepsbtandwalletsignpsbtare both updated to handle peg-in stuff too. Also tests.walletcreatefundedpsbtstill does not handle peg-in data. It will require handling external inputs which the wallet does not do. I think it would be best to first implement external inputs inFundTransactionupstream before allowingwalletcreatefundedpsbtto accept peg-ins.