No more numbering#11
Open
rustyrussell wants to merge 5 commits into
Open
Conversation
Courtesy of "make -C tools/" Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Useful to tell the node to add an HTLC. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Useful for skipping entire tests if something isn't supported. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Requires 323e4f6288f6b66862e8c5819fb651766c908708 in c-lightning. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This makes it more readable and far simpler to renumber. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
niftynei
reviewed
Dec 4, 2019
niftynei
left a comment
niftynei
left a comment
There was a problem hiding this comment.
so good. intuitively, it feels to me like the + and * semantics would be easier to understand if swapped; with + signifying "new step" and * signifying "bullet point, list continuation". this is swapped from their current semantics.
otherwise 👍 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #10 so just use last commit...