Invalid write when shutting down with pending sendpay command

[cdecker]

Issue and Steps to Reproduce

This was flagged by Travis in run 419207343 (rerunning it causes the logs to be thrown away...)

The relevant lines are:

------------------------------- Valgrind errors --------------------------------
Valgrind error file: valgrind-errors.7542
==7542== Invalid write of size 8
==7542==    at 0x41FA16: list_del_ (list.h:327)
==7542==    by 0x41FAD4: destroy_sendpay_command (pay.c:36)
==7542==    by 0x47BEB0: notify (tal.c:235)
==7542==    by 0x47C361: del_tree (tal.c:395)
==7542==    by 0x47C3B1: del_tree (tal.c:405)
==7542==    by 0x47C6E7: tal_free (tal.c:479)
==7542==    by 0x433BEC: daemon_shutdown (daemon.c:110)
==7542==    by 0x4165CD: main (lightningd.c:486)
==7542==  Address 0x61b9550 is 832 bytes inside a block of size 960 free'd
==7542==    at 0x4C2EDEB: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==7542==    by 0x47C42D: del_tree (tal.c:414)
==7542==    by 0x47C6E7: tal_free (tal.c:479)
==7542==    by 0x4165BE: main (lightningd.c:480)
==7542==  Block was alloc'd at
==7542==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==7542==    by 0x47BF1A: allocate (tal.c:245)
==7542==    by 0x47C473: tal_alloc_ (tal.c:421)
==7542==    by 0x4153CA: new_lightningd (lightningd.c:50)
==7542==    by 0x415FC1: main (lightningd.c:323)
==7542== 
==7542== Invalid write of size 8
==7542==    at 0x41FA29: list_del_ (list.h:328)
==7542==    by 0x41FAD4: destroy_sendpay_command (pay.c:36)
==7542==    by 0x47BEB0: notify (tal.c:235)
==7542==    by 0x47C361: del_tree (tal.c:395)
==7542==    by 0x47C3B1: del_tree (tal.c:405)
==7542==    by 0x47C6E7: tal_free (tal.c:479)
==7542==    by 0x433BEC: daemon_shutdown (daemon.c:110)
==7542==    by 0x4165CD: main (lightningd.c:486)
==7542==  Address 0x61b9548 is 824 bytes inside a block of size 960 free'd
==7542==    at 0x4C2EDEB: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==7542==    by 0x47C42D: del_tree (tal.c:414)
==7542==    by 0x47C6E7: tal_free (tal.c:479)
==7542==    by 0x4165BE: main (lightningd.c:480)
==7542==  Block was alloc'd at
==7542==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==7542==    by 0x47BF1A: allocate (tal.c:245)
==7542==    by 0x47C473: tal_alloc_ (tal.c:421)
==7542==    by 0x4153CA: new_lightningd (lightningd.c:50)
==7542==    by 0x415FC1: main (lightningd.c:323)
==7542==
--------------------------------------------------------------------------------

getinfo output

This is commit b9c3850

[cdecker]

Build 419456259 for PR #1847 just had the same issue, and this time I grabbed the logfile: log.txt