Skip to content

dualopen: Refactor dualopen to use interactivetx library #5616

@ddustin

Description

@ddustin

Update dualopen to use interactivetx module for interactive transaction building.

The interactive transaction building routines are being refactored out of dualopen to be used as a general module in three phases:

  1. Code pulled into module & interface made. See Collaborative transaction building #5287
  2. Channeld uses module to implement splicing
  3. Dualopen is updated to use the new module

This issue is for the third phase. Go through openingd/dualopend.c and remove all code that uses the TX_ADD_INPUT/TX_ADD_OUTPUT/TX_REMOVE_INPUT/TX_REMOVE_OUTPUT/TX_COMPLETE and related peer messages and replace them with code using the interface found in common/interactivetx.h

The thinking for this is two fold: dualopen is leaving experimental while splice is entering experimental. Dogfooding the new code in an experimental feature first seems prudent.

Secondly, it will allow an interop test between splicing using the new module and dualopen using the old method. This will give us greater assurances the refactor isn't introducing any unexpected behavior.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions