Custom notifications in rust broken in v25.09rc1

[daywalker90]

Apparently there were more changes than i noticed in #8376. Where previously we got something like this

{"origin":"holdinvoice","payload":{"htlc_expiry":253,"payment_hash":"09682233ad5254b180c36dceac457559c6eccd46905cc4eb03ec5a03503123fd"}}

we now get this:

{"my_notification_name": {"htlc_expiry":253,"payment_hash":"09682233ad5254b180c36dceac457559c6eccd46905cc4eb03ec5a03503123fd"}, "htlc_expiry":253,"payment_hash":"09682233ad5254b180c36dceac457559c6eccd46905cc4eb03ec5a03503123fd"}

which is upsetting cln-plugin since it expects a "payload". I vaguely remember @cdecker talking about notification double wrapping but forgot the details.

What do?

[daywalker90]

Sorry, not upsetting cln-plugin but my own plugin. We should probably atleast include in the Changelog that custom notifications are no longer wrapped in "payload" for crates.

Edit: and the missing "origin" i guess..

[daywalker90]

Also this has to be breaking something somewhere:

#[derive(Clone, Debug, Deserialize, Serialize)]
pub struct CustomMsgNotification {
    pub payload: String,
    pub peer_id: PublicKey,
}

Edit: maybe not, since it's a different kind of custom message....

[rustyrussell]

Damn. We were supposed to do BOTH the new and the old, unless deprecations are disabled!

And then we can remove the old ones. The "origin" is now outside the params object :(

[rustyrussell]

OK, I remember now. I chose not to mangle notifications in the generic code, but fix up the only ones I knew of manually (in libplugin-pay). Obviously this means any custom rust ones just changed. I've chosen to recommend adding a CHANGELOG line, and I'll get Madeline to add that for rc4.