Support debugging with lldb#1327
Merged
Merged
Conversation
ZmnSCPxj
previously requested changes
Apr 5, 2018
| close(batch->to_child); | ||
| close(batch->from_child); | ||
| waitpid(batch->child_pid, NULL, 0); | ||
| while(waitpid(batch->child_pid, NULL, 0) < 0 && errno == EINTR); |
Contributor
There was a problem hiding this comment.
Unfortunately changes to CCAN could should preferably be pushed upstream to CCAN: https://github.com/rustyrussell/ccan
Contributor
|
Tested pass on macOS 10.12.4 |
Contributor
|
Correct fix is to get rid of ptr_valid which is needed by autodata on non-ELF platforms (ie. MacOS). Ideally someone who knows macos would come up with a clever way of doing autodata there? Otherwise we could generate the type_to_string and json_command arrays using grep... |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Apr 6, 2018
In particular, this gets some MacOS fixes from ElementsProject#1327. It also includes a major intmap update which fixes corner cases in traversals, and requires ccan/bitops. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker
pushed a commit
that referenced
this pull request
Apr 6, 2018
In particular, this gets some MacOS fixes from #1327. It also includes a major intmap update which fixes corner cases in traversals, and requires ccan/bitops. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Running with lldb cause SIGINT, which makes waitpid() returns error with errno as EINTR. This patch retry waitpid() to ignore EINTR errors.
Contributor
Author
|
Removed other changes except bitcoind.c from the previous commit. |
Contributor
Author
|
@ZmnSCPxj @rustyrussell I think this patch is ready. Please take a look. |
ZmnSCPxj
approved these changes
Apr 11, 2018
Contributor
|
ACK 474cc1b |
Member
|
ACK 474cc1b |
Saibato
pushed a commit
to Saibato/lightning
that referenced
this pull request
Apr 17, 2018
In particular, this gets some MacOS fixes from ElementsProject#1327. It also includes a major intmap update which fixes corner cases in traversals, and requires ccan/bitops. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1093
Running with lldb cause SIGINT, which makes waitpid(), read()
returns error with errno as EINTR. This patch retry these calls
to ignore EINTR errors.
Tested only on macOS.