test_lightningd.py: Make test_penalty_inhtlc not fail due to reconnect.#1422
Closed
ZmnSCPxj wants to merge 1 commit into
Closed
test_lightningd.py: Make test_penalty_inhtlc not fail due to reconnect.#1422ZmnSCPxj wants to merge 1 commit into
ZmnSCPxj wants to merge 1 commit into
Conversation
The test disconnects at `=WIRE_COMMITMENT_SIGNED-nocommit`, then reconnects to continue `REVOKE_AND_ACK`, so I think it should indeed reconnect. This was introduced in ElementsProject#1408. I am uncertain why, the last commit in that PR passed, but an intermediate commit failed on `test_penalty_inhtlc`: https://travis-ci.org/ElementsProject/lightning/jobs/370024920
Contributor
|
This was fixed properly in first commit of #1322 ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test disconnects at
=WIRE_COMMITMENT_SIGNED-nocommit,then reconnects to continue
REVOKE_AND_ACK, so I think itshould indeed reconnect.
This was introduced in #1408.
I am uncertain why, the last commit in that PR passed, but an
intermediate commit failed on
test_penalty_inhtlc:https://travis-ci.org/ElementsProject/lightning/jobs/370024920