A number of pytest fixes and a minor cleanup in gossip#1474
Merged
Conversation
Signed-off-by: Christian Decker <decker.christian@gmail.com>
This is a leftover from before splitting the `gossip_store` injection path from the handling of gossip messages. Signed-off-by: Christian Decker <decker.christian@gmail.com>
Signed-off-by: Christian Decker <decker.christian@gmail.com>
The flakyness is probably due to timing issues when reorging. Signed-off-by: Christian Decker <decker.christian@gmail.com>
Contributor
|
ACK b166c9a |
ZmnSCPxj
approved these changes
May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My weekly cleanups, this week early, since the parallel merge of the network rework PR #1450 and my PR #1473 unfixed the fix right away.