external/Makefile: Change HOST to MAKE_HOST#1520
Merged
Merged
Conversation
ZmnSCPxj
reviewed
May 22, 2018
Contributor
ZmnSCPxj
left a comment
ZmnSCPxj
left a comment
There was a problem hiding this comment.
Both libwally and libsodium use the internal names MAKE_HOST, maybe better to use that name instead of AUTO_HOST.
The Real Solution is of course to formally define how cross-compilation should really work, rather than the current workarounds used.
Proposed fix for issue #1231 - FreeBSD (tcsh) build problem due to HOST environment variable. The variable is used for cross-compilation. The process may be improved even further in the future. So far this hot fix.
Contributor
Author
|
@ZmnSCPxj thank you for feed-back! I changed it appropriately. |
jsarenik
changed the title
ZmnSCPxj
approved these changes
May 23, 2018
Contributor
|
ACK af804ef |
Contributor
Author
|
@ZmnSCPxj |
Contributor
Author
|
Ref: #1533 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for issue #1231 - FreeBSD (tcsh) build problem due
to HOST environment variable.