Add default init method for pylightning plugins#2271
Closed
conscott wants to merge 1 commit into
Closed
Conversation
conscott
changed the title
Member
|
Hopefully #2237 will be merged soon. It also contains the fix of de-indenting the self.init re-assignment, which also fixes this alone, without the need to add a default |
cdecker
reviewed
Jan 16, 2019
| if 'init' in self.methods: | ||
| self.init = self.methods['init'] | ||
| self.methods['init'] = self._init | ||
| self.methods['init'] = self._init |
Member
There was a problem hiding this comment.
I think this is one of the patches in #2237 as well.
| return None | ||
|
|
||
| # default init method does nothing | ||
| def init(self, options, configuration, plugin): |
Member
There was a problem hiding this comment.
If you keep the self.init = None line above this is not really required.
Collaborator
Author
|
👍 sounds good, must have missed that before. I'll try to give #2271 another honest review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making python plugins, it should be okay to not implement an
initmethod. Currently the plugin will crash if it is not supplied (it's the first thing lightningd calls), so this change adds a default that does nothing.You can test by removing these lines from the helloworld.py plugin, and also note that the
self._initmethod is still called regardless.