Skip to content

lightningd: fix crash when peer disconnects after fundchannel_start, before cancel/complete#2931

Merged
cdecker merged 1 commit into
ElementsProject:masterfrom
rustyrussell:fundchannel-crash
Aug 9, 2019
Merged

lightningd: fix crash when peer disconnects after fundchannel_start, before cancel/complete#2931
cdecker merged 1 commit into
ElementsProject:masterfrom
rustyrussell:fundchannel-crash

Conversation

@rustyrussell
Copy link
Copy Markdown
Contributor

Fixes: #2831

…before cancel/complete

Fixes: ElementsProject#2831
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added Type::Bug An error, flaw, or fault that produces an incorrect or unexpected result crash funding labels Aug 9, 2019
@rustyrussell rustyrussell added this to the 0.7.2 milestone Aug 9, 2019
@rustyrussell rustyrussell requested a review from niftynei August 9, 2019 06:02
Copy link
Copy Markdown
Contributor

@ZmnSCPxj ZmnSCPxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a615fd1

Looks ok to me, but I wonder if it is possible to add a test?

@cdecker cdecker merged commit 710d015 into ElementsProject:master Aug 9, 2019
@darosior
Copy link
Copy Markdown
Contributor

darosior commented Aug 9, 2019

@ZmnSCPxj I made one here rustyrussell#6 but was not quick enough ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crash funding Type::Bug An error, flaw, or fault that produces an incorrect or unexpected result

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fundchannel_complete crashes on peer_error?

4 participants