EXPERIMENTAL: simplified commitment support#3010
Merged
niftynei merged 11 commits intoSep 10, 2019
Merged
Conversation
rustyrussell
force-pushed
the
guilt/simplfied_commitment
branch
2 times, most recently
from
904297a to
5f074ab
Compare
cdecker
changed the title
rustyrussell
force-pushed
the
guilt/simplfied_commitment
branch
from
fa0dd9e to
4fc54b3
Compare
rustyrussell
force-pushed
the
guilt/simplfied_commitment
branch
from
4fc54b3 to
1f98677
Compare
Contributor
Author
|
Rebased.... |
rustyrussell
force-pushed
the
guilt/simplfied_commitment
branch
from
1f98677 to
66ba2a4
Compare
…ent. Insist it be prefixed with '* '. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Somehow this change got lost, but it's needed for option_static_remotekey,
to quote gen_peer_wire_csv:
msgtype,channel_reestablish,136
msgdata,channel_reestablish,channel_id,channel_id,
msgdata,channel_reestablish,next_commitment_number,u64,
msgdata,channel_reestablish,next_revocation_number,u64,
msgdata,channel_reestablish,your_last_per_commitment_secret,byte,32,option_data_loss_protect,option_static_remotekey
msgdata,channel_reestablish,my_current_per_commitment_point,point,,option_data_loss_protect
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Aka. BOLTVERSION=930a9b44076a8f25a8626b31b3d5a55c0888308c from lightning/bolts#642 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…emotekey` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We don't rotate key for option_static_remotekey, so we don't need this point for such channels. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The largest change is inside hsmd: it hands a null per-commitment key to the wallet to tell it to spend the to_remote output. It can also now resolve unknown commitments, even if it doesn't have a possible_remote_per_commitment_point from the peer. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…atic_remotekey Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
/bin/sh: 1: ccan/ccan/cdump/tools/cdump-enumstr: Text file busy
make[1]: *** [common/Makefile:81: common/gen_htlc_state_names.h] Error 2
make[1]: *** Waiting for unfinished jobs....
The fix is to make sure all generated headers are made first, and
thus cdump-enumstr.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
lightning/bolts@531c8d7 In this one, we always send my_current_per_commitment_point, though it's ignored. And we have our official feature numbers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/simplfied_commitment
branch
from
66ba2a4 to
7529744
Compare
Collaborator
|
ACK 7529744 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements option_simplified_commitment as described in lightning/bolts#642
It passes the latest protocol tests for option_simplified_commitment in: https://github.com/ElementsProject/lightning-rfc-protocol-test