query_messages: fail the connection if the peer is not on the same network#3123
Merged
Conversation
…_range' And correct some typos
… have up-to-date infos It is most likely not on the same network, and in any case not a good peer to gossip with.
darosior
changed the title
cdecker
reviewed
Oct 2, 2019
Member
cdecker
left a comment
cdecker
left a comment
There was a problem hiding this comment.
Minor question about the error returned, otherwise looks good 👍
Comment on lines
+682
to
+684
| return towire_errorfmt(peer, NULL, | ||
| "No up to date infos about this network: %s", | ||
| tal_hex(tmpctx, msg)); |
Member
There was a problem hiding this comment.
Should we maybe add the chain hash instead of the entire message they sent us?
Contributor
Author
There was a problem hiding this comment.
We send the whole message for all errors, I can make it chain_hash instead but that's anyway not very useful to the peer (he kind of errored first)
niftynei
approved these changes
Oct 9, 2019
Collaborator
|
ACK d78d888 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR :
handle_query_short_channel_idsrespond withcompleteflag set to0when we are queried for an unknownchain_hash.handle_reply_channel_rangeandhandle_reply_short_channel_ids_endfail the connection if the peer says it does not have up to date informations about our network. (related to bolt07: explicit that the peer may fail the connection if wrong chain_hash in query_messages lightning/bolts#678)