Skip to content

tool/hsmtool: add a 'guesstoremote' command#3292

Merged
cdecker merged 2 commits into
ElementsProject:masterfrom
darosior:hsmtools_static_remotekey
Nov 29, 2019
Merged

tool/hsmtool: add a 'guesstoremote' command#3292
cdecker merged 2 commits into
ElementsProject:masterfrom
darosior:hsmtools_static_remotekey

Conversation

@darosior
Copy link
Copy Markdown
Contributor

@darosior darosior commented Nov 25, 2019

This is the static_remotekey-only version of #3217 (since I noticed to_remote keys are (/were) actually derived from the local per_commitment_point, by the way if someone could explains me why I'd be interested ^^).

I added a note to the README about it since all major implementations will implement it, it's likely that most of the newly created channels will enable option_static_remotekey in the near future and that this might be useful.

@cdecker
Copy link
Copy Markdown
Member

cdecker commented Nov 25, 2019

Nice tool, my main concern is that we're starting to crowd the README.md again, putting niche things in there and distracting from the simple getting started part. We should probably start working on an faq that collects these things instead.

cdecker
cdecker reviewed Nov 25, 2019
View reviewed changes
Comment thread README.md Outdated
Comment thread tools/hsmtool.c Outdated
Comment thread tools/hsmtool.c Outdated
@cdecker cdecker self-assigned this Nov 25, 2019
@cdecker cdecker added the wallet label Nov 25, 2019
@darosior
Copy link
Copy Markdown
Contributor Author

darosior commented Nov 25, 2019

Nice tool, my main concern is that we're starting to crowd the README.md again, putting niche things in there and distracting from the simple getting started part. We should probably start working on an faq that collects these things instead.

Yeah I was not sure about the README addtion.
About the FAQ that's my feeling too, maybe we could add an intro (we would repeat things but I think it's OK) and a FAC to https://lightning.readthedocs.io/, maybe both on the homepage until we have too many questions ?

@darosior
tool/hsmtool: add a 'guesstoremote' command
a796a2d 
This, in the case of data loss on a channel with `option_static_remotekey`
negotiated, allows to likely (if the dbid is not unreasonable) recover
the funds from a remote unilateral close just with the hsm_secret.

Changelog-added: A new command, 'guesstoremote', is added to the hsmtool. It is meant to be used to recover funds after an unilateral close of a channel with `option_static_remotekey` enabled.
@darosior
tools/hsmtool: correct bad access to argv[]
e0988a2
@darosior darosior force-pushed the hsmtools_static_remotekey branch from 73924d8 to e0988a2 Compare November 25, 2019 16:39
@darosior
Copy link
Copy Markdown
Contributor Author

darosior commented Nov 25, 2019

Thanks for the review !
Actually the premature argv[] access was used in all commands and so dirty that I added a drive-by commit to fix it.

@cdecker
Copy link
Copy Markdown
Member

cdecker commented Nov 29, 2019

ACK e0988a2

@cdecker
Copy link
Copy Markdown
Member

cdecker commented Nov 29, 2019

I think we should earmark these things for later collection into an faq in the docs 😉

@cdecker cdecker merged commit 36e8d83 into ElementsProject:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdecker cdecker cdecker left review comments

Assignees

@cdecker cdecker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darosior @cdecker