Add network to init message#3300
Merged
Merged
Conversation
cdecker
reviewed
Nov 28, 2019
We are going to signal the genesis block hash in the init message.
darosior
force-pushed
the
network_to_init
branch
from
ebbcb0e to
1079696
Compare
Contributor
Author
|
Rebased to correct the use of |
Changelog-Added: protocol: We now signal the network we are running on at init.
darosior
force-pushed
the
network_to_init
branch
from
1079696 to
a445b9e
Compare
rustyrussell
approved these changes
Nov 29, 2019
Contributor
rustyrussell
left a comment
rustyrussell
left a comment
There was a problem hiding this comment.
Ack a445b9e
Technically, this isn't in the spec yet, so it should be wrapped in EXPERIMENTAL_FEATURES until it is. However, all the spec needs is interop testing, so if we can do that with LND or Eclair (once they've implemented it!) we can apply this.
If specified, this will add the corresponding chain_hash to the init message.
darosior
force-pushed
the
network_to_init
branch
from
a445b9e to
bcc7e70
Compare
Member
|
Re-applying @rustyrussell's ACK, and merging: ACK bcc7e70 |
rustyrussell
reviewed
Dec 1, 2019
Comment on lines
+78
to
+82
| if (!tlvs->networks->chains) { | ||
| status_peer_debug(&peer->id, | ||
| "bad networks TLV in init '%s', closing", | ||
| tal_hex(tmpctx, msg)); | ||
| return io_close(conn); |
Contributor
There was a problem hiding this comment.
Note this is technically redundant, since it's covered elegently by the next part anyway.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements lightning/bolts#682