4013 fixups#4030
Merged
Merged
Conversation
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Contributor
Author
|
Looks like i cannot ask for review directly, so ping @rustyrussell |
cdecker
requested changes
Sep 9, 2020
Member
cdecker
left a comment
cdecker
left a comment
There was a problem hiding this comment.
Leaks cc in cancel_channel_before_broadcast.
As the cmd gets freed on a received error, the node id in which we iterate in `process_check_funding_broadcast` may gets freed while we are using it. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
darosior
force-pushed
the
4013_fixups
branch
from
e6623c3 to
00f2d2a
Compare
Contributor
Author
|
Thanks, amended |
cdecker
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixups from #4013 (a mem fix detected by ASAN and a build cleanup), so they are part of 0.9.1 even if it takes more time to make Travis happy with ASAN builds.