Change sqlite3_busy_timeout to 60 seconds, add warnings re: litestream.#4867
Merged
Conversation
ZmnSCPxj
force-pushed
the
fix-litestream
branch
2 times, most recently
from
90079f0 to
6cb6e5a
Compare
Collaborator
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
LGTM, I have only a small question, because I'm missing some things.
vincenzopalazzo
approved these changes
Oct 15, 2021
Collaborator
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
Oh, I got it. my fault sorry.
ack 6cb6e5a
Contributor
|
Let's just increase the default to 30 or 60 seconds. I mean, we could do better, but the user surely prefers a delay to a crash! Providing knobs like this is a last resort, IMHO. |
Closes: ElementsProject#4860 ChangeLog-Added: With `sqlite3` db backend we now use a 60-second busy timer, to allow backup processes like `litestream` to operate safely.
…mp` is safe(r) now.
ZmnSCPxj
force-pushed
the
fix-litestream
branch
from
6cb6e5a to
2434e4d
Compare
Contributor
Author
|
Use 60-second timeout without exposing new option to user, updated |
ZmnSCPxj
changed the title
--sqlite3-busy-timeout option, add warnings re: litestream.sqlite3_busy_timeout to 60 seconds, add warnings re: litestream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4860
Fixes: #4857 if @x3nb63 can confirm
We need to specify versions in
BACKUP.mdsince it is published on https://lightning.readthedocs.io/BACKUP.html and users might assume the recommendation applies to all versions;litestreamwill reliably work after 5bf2b5c and on reasonably fast media/low-load conditions.