Clnrest: update config param with cln prefix#6857
Merged
nepet merged 1 commit intoNov 16, 2023
Merged
Conversation
nepet
approved these changes
Nov 10, 2023
Member
There was a problem hiding this comment.
All I got are just nits, besides maybe the sleeps in the tests but if they don't introduce more flakes this is fine as well. I really like the level of detail in the tests and how much easier the rpc method call gets using RuneErrors.
ACK 128eaf3
nepet
reviewed
Nov 10, 2023
ShahanaFarooqui
force-pushed
the
clnrest-config-params
branch
from
128eaf3 to
c42efb0
Compare
Collaborator
Author
Shout out to @tonyaldon for detailed testcases :). Two sleep timers and request retries are necessary for CI to succeed and I removed other timers. |
This will allow users to use clnrest with c-lightning-REST without conflicts. It was required for applications to have enough time for migrating from c-lightning-REST to clnrest. Changelog-Changed: config option `rest-certs` changed to `clnrest-certs` config option `rest-protocol` changed to `clnrest-protocol` config option `rest-host` changed to `clnrest-host` config option `rest-port` changed to `clnrest-port` config option `rest-cors-origins` changed to `clnrest-cors-origins` config option `rest-csp` changed to `clnrest-csp`
nepet
force-pushed
the
clnrest-config-params
branch
from
c42efb0 to
70d18f4
Compare
Member
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to use clnrest with c-lightning-REST without conflicts.
It was required for applications to have enough time for migrating from c-lightning-REST to clnrest.
Changelog-Changed:
config option
rest-certschanged toclnrest-certsconfig option
rest-protocolchanged toclnrest-protocolconfig option
rest-hostchanged toclnrest-hostconfig option
rest-portchanged toclnrest-portconfig option
rest-cors-originschanged toclnrest-cors-originsconfig option
rest-cspchanged toclnrest-csp