msggen: add low level fundchannel methods#7231
Merged
cdecker merged 1 commit intoApr 23, 2024
Merged
Conversation
Collaborator
Author
|
Notice that i changed the |
cdecker
previously requested changes
Apr 18, 2024
Member
cdecker
left a comment
cdecker
left a comment
There was a problem hiding this comment.
Just a small issue with the change in denomination in the schema (it's sat whenever on-chain is involved, and msat otherwise).
| }, | ||
| "amount": { | ||
| "type": "sat", | ||
| "type": "msat", |
Member
There was a problem hiding this comment.
This change is wrong:
amount is the satoshi value that we will contribute to the channel.
This value will be added to the provided PSBT in the output which is
encumbered by the 2-of-2 script for this channel.
daywalker90
force-pushed
the
fundchannel_low_level
branch
from
91807e6 to
9bdc515
Compare
Collaborator
Author
|
rebased on #7238 |
cdecker
force-pushed
the
fundchannel_low_level
branch
from
9bdc515 to
342e0b2
Compare
Member
|
This was a clean rebase, I'll merge asap. |
cdecker
dismissed
their stale review
The sat vs msat discussion predates this PR.
cdecker
force-pushed
the
fundchannel_low_level
branch
from
342e0b2 to
2a8a5f4
Compare
Member
|
Rebased on top of |
Changelog-None
cdecker
force-pushed
the
fundchannel_low_level
branch
from
2a8a5f4 to
c711dc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on: #7215 + #7217 + #7218 and the fix from #7230
This PR adds the following low level fundchannel methods in msggen:
fundchannel_cancelfundchannel_completefundchannel_start