Purge channels from the DB after they have been irrevocably committed#740
Merged
Merged
Conversation
Signed-off-by: Christian Decker <decker.christian@gmail.com>
cdecker
added
Type::Bug
Signed-off-by: Christian Decker <decker.christian@gmail.com>
cdecker
force-pushed
the
forget-channels
branch
from
09c537f to
ccdad10
Compare
rustyrussell
approved these changes
Jan 25, 2018
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 12, 2020
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 12, 2020
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 12, 2020
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 12, 2020
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 12, 2020
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 12, 2020
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 12, 2020
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 13, 2020
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 13, 2020
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 13, 2020
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 16, 2020
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 19, 2020
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
m-schmoock
added a commit
to m-schmoock/lightning
that referenced
this pull request
Mar 19, 2020
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
cdecker
pushed a commit
that referenced
this pull request
Mar 19, 2020
Changelog-Fixed: Use lightning-rfc #740 feespike margin factor of 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may cause the lingering
onchaind_mutualchannels in #721. Channels didn't get removed from the DB even though they were removed in memory. Alternatively we could mark the channels as resolved by setting their status to something that we ignore when loading.Dropping the channels cascades to remove all dependent tables, so this suffices to clear everything.