bookkeeper, meet splicing#7533
Merged
ShahanaFarooqui merged 2 commits intoAug 8, 2024
Merged
Conversation
niftynei
force-pushed
the
nifty/bkpr_splice_one
branch
2 times, most recently
from
f4c7ffd to
a6c5443
Compare
niftynei
force-pushed
the
nifty/bkpr_splice_one
branch
from
a6c5443 to
3ccfb9c
Compare
ddustin
reviewed
Aug 6, 2024
| struct amount_msat orig_our_msats, | ||
| struct amount_sat orig_funding_sats, | ||
| struct bitcoin_outpoint *funding, | ||
| u32 blockheight, struct bitcoin_txid *txid, const struct channel_inflight *inflight) |
niftynei
force-pushed
the
nifty/bkpr_splice_one
branch
2 times, most recently
from
ba32cf8 to
61996dd
Compare
We weren't properly notifying that a channel output has been spent in the case of it being spent in a splice. This fixes the notification side of the equation, however there's still some issues remaining for the bookkeeper side (to come). Changelog-Fixed: We now send a `coin_movement` notification for splice confirmations of channel funding outpoint spends.
We do some fancy accounting for channel closures; since we're tagging splice txs as closes we need to mark them as splices so we can treat them as any other 'normal' on chain event.
niftynei
force-pushed
the
nifty/bkpr_splice_one
branch
from
61996dd to
69bd5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the coin-movment notifications and the bookkeeper respectively so that splices are properly accounted for (quite literally).
Prior to this we haven't been logging the spend of the funding output for splices (they're simply not recorded).
Will update with a PR built on #6980 which includes tests for these.