msggen: add missing methods for 24.11#7549
Conversation
607a9a0 to
975a16c
Compare
|
I'm going to defer these because they're still experimental and I want to reserve the right to change them radically! Maybe by the time we're into next release @Lagrang3 and I will have more confidence? |
975a16c to
c0fb3e3
Compare
c0fb3e3 to
4968fdb
Compare
|
Ack 4968fdb Several other PRS will conflict (damn generated files) so I'll wait a bit before rebasing and merging this |
|
Want me to do a separate PR for the rest or add them here? |
All the other API changes are merged now, so go wild! |
Changelog-None
Changelog-None
4968fdb to
525ef0b
Compare
|
Rebased and added missing methods listed in OP, these are now all missing methods that were added since 24.08 |
|
I had to revert this for rc2, as the rust build broke. Will try again after rc2... |
|
I've looked through the CI jobs. It worked a couple of times and then failed in your rc2 PR run. Looking at the logs it looks to me like it still didn't wait "long" enough for the generated files to be there completely. |
|
It's not enough that the files exist apparently. The generation could still be ongoing and the compiler would use a half finished file and then complain about missing things that are not missing in fully generated files. |
|
Hmm... weird! I'll look deeper... But there were crashes in rc1 so I want to release rc2 now :( |
|
I suspect that MSGGEN_GEN_ALL -> MSGGEN_GENALL change, TBH. We can depend on both. I'll try. |
We don't want to fall out of sync again, right?! @rustyrussell @ShahanaFarooqui
EDIT: reworked the PR to include all the missing rpc commands for 24.11:
Aswell as: