Skip to content

Docker refactoring#3

Draft
Dim0N22 wants to merge 2 commits into
ElementumOrg:masterfrom
Dim0N22:docker_refactoring
Draft

Docker refactoring#3
Dim0N22 wants to merge 2 commits into
ElementumOrg:masterfrom
Dim0N22:docker_refactoring

Conversation

@Dim0N22
Copy link
Copy Markdown

@Dim0N22 Dim0N22 commented Mar 28, 2021

This PR is related to PR#2 in ElementumOrg/cross-compiler.
It introduces a couple of improvements:

  • Unified image tags (elementumorg/cross-compiler:base instead of cross-compiler:base)
  • Dockerfile uses multistage builds to improve performance and minimize resulting image
  • Library versions can be changed independently without affecting others. For example changing boost version won't trigger rebuid for swig.
  • If you use Docker 18.09+, you can set DOCKER_BUILDKIT=1 to build multiple indepdendent stages in parallel. This further improves build speed

I've tested it and successfully built libtorrent for android-arm.
This is a draft PR but I want to work on all other images as well.
Let me know what you think.

@Dim0N22 Dim0N22 marked this pull request as draft March 28, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant