Configure I18n from tess.yml #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead read them from tess.yml.
This commit introduces a simpler way to configure I18n's fallbacks[1]
than Rails' provides, by adding a simple translation layer driven by
two `tess.yml` options. The driver for this is the need for easily
configuring region-specific locales in TeSS, while at the same time
providing for a future source of clean source of desired locales to
show in a UI chooser for users.
Though I18n has a configuration option for available locales (and
Rails too), locales not listed in that option won't be considered for
sources of translations.
[1] Fallback is a concept from I18n that allows to use translations
from a more general locale than specified, e.g.: a request for a
translation to locale "en-CA", if not found, will fallback to
search the translations to "en".
This enables using a region-specific locale to get easily
localized dates, but still use the default translations files. It
also allows to have region-specific with partial coverage
(i.e.: customizations of some translations only).
This covers a specific case that might not apply to all I18n users. Also, Rails already does this when `fallbacks` is `true`[1]. [1] https://github.com/rails/rails/blob/7-0-stable/activesupport/lib/active_support/i18n_railtie.rb#L102
fbacall
approved these changes
Nov 28, 2024
Member
fbacall
left a comment
fbacall
left a comment
There was a problem hiding this comment.
Thanks for this!
I'm just going to trust you have manually tested this using e.g. the rfc4646 fallback option with subtags, because we don't yet have a clean, automated way of testing using different configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The main changes allow for configuring I18n from tess.yml.
Motivation and context
This allows each deployment of TeSS to configure I18n without having to maintain local code customizations. This in turn is motivated by requirements of the National Training Discovery portal project of the Digital Research Alliance of Canada.
Screenshots
No visible changes.
Checklist
to license it to the TeSS codebase under the
BSD license.