Skip to content

Comments

Fixed "Our Events" acting as a link#9

Merged
arjunomray merged 2 commits intoElixirTechCommunity:mainfrom
vaibhavxtripathi:main
Dec 30, 2024
Merged

Fixed "Our Events" acting as a link#9
arjunomray merged 2 commits intoElixirTechCommunity:mainfrom
vaibhavxtripathi:main

Conversation

@vaibhavxtripathi
Copy link

Fixed the "Our Events" page heading acting as a link opening the events section in the new tab.
The new behavior is set to do nothing when clicked on the page heading.

@arjunomray
Copy link

when you remove a functionality don't comment the code instead just delete it.

@vaibhavxtripathi
Copy link
Author

Okay sir. Will update and push again.

@vaibhavxtripathi
Copy link
Author

Deleted the redundant code. @arjunomray

@arjunomray
Copy link

arjunomray commented Dec 30, 2024

lgtm 🎉

@arjunomray
Copy link

also for the next PRs make sure to make a separate branch, don't make PRs on main

@arjunomray arjunomray merged commit 6a60031 into ElixirTechCommunity:main Dec 30, 2024
@vaibhavxtripathi
Copy link
Author

Okay sir. Noted. Thank you.

dewank07 added a commit that referenced this pull request May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants