Skip to content

try fix installs on MacOS#37

Closed
tgolsson wants to merge 9 commits intomainfrom
ts/install-monterey
Closed

try fix installs on MacOS#37
tgolsson wants to merge 9 commits intomainfrom
ts/install-monterey

Conversation

@tgolsson
Copy link
Copy Markdown
Member

@tgolsson tgolsson commented Apr 11, 2022

To ensure functionality on MacOS this PR does the following:

  • replaces torch with a CPU-variant
  • replaces box2d with box2d-py, which is OpenAI's fork

@tgolsson tgolsson requested a review from singhblom as a code owner April 11, 2022 20:47
singhblom
singhblom approved these changes Apr 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@singhblom singhblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Are there any similar issues on windows? When I quickly tried to reinstall on windows after poetry got added back I failed but haven't had the time to investigate.

@tgolsson
Copy link
Copy Markdown
Member Author

tgolsson commented Apr 13, 2022

This doesn't work very well due to python-poetry/poetry#3959 -- I'm working on a PR to resolve that in my free time; will see when I get it fixed. I've got a WIP that solves half of it but it's a bit wonky to test M1 specifically since I don't have one.

@singhblom
Copy link
Copy Markdown
Member

singhblom commented Apr 13, 2022

Sorry Tom I'm on vacation and can't ok you getting an M1 right now.

@tgolsson
Copy link
Copy Markdown
Member Author

tgolsson commented Apr 13, 2022

Some more progress, fix working but maybe the wrong one... python-poetry/poetry#3959 (comment)

@tgolsson
Copy link
Copy Markdown
Member Author

tgolsson commented Jun 8, 2022

Still waiting for python-poetry/poetry#5442 to get merged...

@tgolsson
Copy link
Copy Markdown
Member Author

tgolsson commented Nov 1, 2022

Will take another stab at this but since this predates PDM I'll redo it.

@tgolsson tgolsson closed this Nov 1, 2022
@tgolsson tgolsson deleted the ts/install-monterey branch February 17, 2023 22:04
JonasHedEng pushed a commit that referenced this pull request Jun 25, 2024
@jaxs-ribs
Update erupt-gym to work with gymnasium (#37)
fc7b1a5 
* Make gymnasium work

* Remove tfevents

* wip

* Remove prints

* Fmt

* Remove experiment name from config

* Add experiment name to args parsing

* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@singhblom singhblom singhblom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tgolsson @singhblom