This repository was archived by the owner on Oct 31, 2025. It is now read-only.
inline asm!: support writing _ in lieu of return types, for basic inference.#376
Merged
mergify[bot] merged 4 commits intoEmbarkStudios:mainfrom Jan 20, 2021
LykenSol:asm-infer
Merged
inline asm!: support writing _ in lieu of return types, for basic inference.#376mergify[bot] merged 4 commits intoEmbarkStudios:mainfrom LykenSol:asm-infer
mergify[bot] merged 4 commits intoEmbarkStudios:mainfrom
LykenSol:asm-infer
Conversation
eddyb
commented
Jan 14, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk of this PR is the first commit, containing a basic type constraint system for SPIR-V instructions, which I've been working on as a prerequisite for #300 (see module-scope doc comment for its limitations).
What I've done with inline
asm!is demonstrate the use of those constraints to alleviate the need to write sometypeof*{...}, letting the user write just_instead, and having the type be inferred automatically.However,
asm!inference is merely a potential usecase I thought of while working on the type constraint system, and I don't have a strong opinion on keeping it (this is partly the reason why I haven't made it fully-featured yet).