This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Unbreak CI (fix control_barrier and memory_barrier tests).#577
Closed
eddyb wants to merge 1 commit intoEmbarkStudios:mainfrom
LykenSol:fix-ci
Closed
Unbreak CI (fix control_barrier and memory_barrier tests).#577eddyb wants to merge 1 commit intoEmbarkStudios:mainfrom LykenSol:fix-ci
eddyb wants to merge 1 commit intoEmbarkStudios:mainfrom
LykenSol:fix-ci
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#519 was landed with a stale (2 week old at this point) CI, predating the introduction of Vulkan validation on CI, and now
mainitself doesn't pass CI anymore.I don't like my
Semanticsbodge, but it being a bitset means usingenumis just wrong.I could've switched it to
bitflags!but it seemed easier to just work around it for now.