This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Address review comments on #576 (Deprecate #[spirv(block)] and auto-wrap in "interface blocks" instead).#580
Merged
eddyb merged 6 commits intoEmbarkStudios:mainfrom Apr 8, 2021
LykenSol:autoblock-followup
Merged
Address review comments on #576 (Deprecate #[spirv(block)] and auto-wrap in "interface blocks" instead).#580eddyb merged 6 commits intoEmbarkStudios:mainfrom LykenSol:autoblock-followup
eddyb merged 6 commits intoEmbarkStudios:mainfrom
LykenSol:autoblock-followup
Conversation
…_interface_for_param`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is needed because #576 got merged before all the reviews could be done)
Same as last time, most of the commits are small(er) refactors. The last one consolidates all the logic to do with adjusting the global interface
OpVariablepointer to match the entryfncall argument, intodeclare_shader_interface_for_param, instead of being nested in some closure inshader_entry_stub.