Use DefaultMetadataLoader for loading dylib metadata#698
Use DefaultMetadataLoader for loading dylib metadata#698khyperia merged 1 commit intoEmbarkStudios:mainfrom
Conversation
|
Looks like the Android CI is just broken nowadays, but we should definitely merge this PR whenever CI is unbroken. |
|
bevyengine/bevy#2533 was the "fix" for bevy. Basically uninstall the broken android build tools version 31 first, so |
khyperia
left a comment
There was a problem hiding this comment.
If you switch archives from tar to ar archives, it would be possible to use
DefaultMetadataLoaderfor everything.
What do you mean by "everything"? I guess like, yeah, sure, sounds great, tbh I didn't realize there was a difference between tar and ar archives, haha.
Anyway, #701 should have fixed the CI, could you rebase?
Head branch was pushed to by a user without write access
For rlibs too and not just for dylibs.
Ar archives are much more limited. For example they don't support directories, symlinks, etc. On the other hand both the gnu and bsd flavor support a symbol table that maps from symbol name to the object file that contains said symbol. This can improve linker speed and is required by most linkers.
Done |
If you switch archives from tar to ar archives, it would be possible to use
DefaultMetadataLoaderfor everything.