Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Comments

Fix example-runner-ash's validation layer errors#700

Merged
khyperia merged 1 commit intoEmbarkStudios:mainfrom
hatoo:fix-validation-error-ash-pr
Aug 3, 2021
Merged

Fix example-runner-ash's validation layer errors#700
khyperia merged 1 commit intoEmbarkStudios:mainfrom
hatoo:fix-validation-error-ash-pr

Conversation

@hatoo
Copy link
Contributor

@hatoo hatoo commented Jul 31, 2021

This PR fixes example-runner-ash's errors which are displayed with --debug-layer option.

> cargo run --bin example-runner-ash -- --debug-layer
   Compiling example-runner-ash v0.4.0-alpha.10 (C:\Users\hato2\Desktop\fork\rust-gpu\examples\runners\ash)
    Finished dev [unoptimized + debuginfo] target(s) in 2.48s
     Running `target\debug\example-runner-ash.exe --debug-layer`
    Finished release [optimized] target(s) in 0.17s
INFO:
GENERAL [Loader Message (0)] : Inserted device layer VK_LAYER_KHRONOS_validation (C:\VulkanSDK\1.2.182.0\Bin\.\VkLayer_khronos_validation.dll)

INFO:
GENERAL [Loader Message (0)] : Inserted device layer VK_LAYER_NV_optimus (C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_4a746d937e6a7240\.\nvoglv64.dll)

ERROR:
VALIDATION [VUID-VkShaderModuleCreateInfo-pCode-01091 (-1480880714)] : Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-01091 ] Object 0: handle = 0x20ea37c94d8, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xa7bb8db6 | vkCreateShaderModule(): The SPIR-V Capability (VulkanMemoryModel) was declared, but none of the requirements were met to use it. The Vulkan spec states: If pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.2.182.0/windows/1.2-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-01091)

ERROR:
VALIDATION [VUID-VkShaderModuleCreateInfo-pCode-04147 (1028204675)] : Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-04147 ] Object 0: handle = 0x20ea37c94d8, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x3d492883 | vkCreateShaderModule(): The SPIR-V Extension (SPV_KHR_vulkan_memory_model) was declared, but none of the requirements were met to use it. The Vulkan spec states: If pCode declares any of the SPIR-V extensions listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.2.182.0/windows/1.2-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-04147)

ERROR:
VALIDATION [VUID-VkShaderModuleCreateInfo-pCode-01091 (-1480880714)] : Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-01091 ] Object 0: handle = 0x20ea37c94d8, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xa7bb8db6 | vkCreateShaderModule(): The SPIR-V Capability (VulkanMemoryModel) was declared, but none of the requirements were met to use it. The Vulkan spec states: If pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.2.182.0/windows/1.2-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-01091)

ERROR:
VALIDATION [VUID-VkShaderModuleCreateInfo-pCode-04147 (1028204675)] : Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-04147 ] Object 0: handle = 0x20ea37c94d8, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x3d492883 | vkCreateShaderModule(): The SPIR-V Extension (SPV_KHR_vulkan_memory_model) was declared, but none of the requirements were met to use it. The Vulkan spec states: If pCode declares any of the SPIR-V extensions listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.2.182.0/windows/1.2-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-04147)

Although #693 is needed to run in my environment, it's not contained in this PR.

@hatoo hatoo requested review from VZout, fu5ha and khyperia as code owners July 31, 2021 10:51
Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'd also like @VZout's review (is the API bump needed? I guess it doesn't matter that much either way, though.)

@hrydgard hrydgard removed the request for review from fu5ha August 2, 2021 07:42
@khyperia
Copy link
Contributor

khyperia commented Aug 3, 2021

I believe #701 should have fixed the CI, could you rebase?

@hatoo hatoo force-pushed the fix-validation-error-ash-pr branch from dc391a1 to ec50a4c Compare August 3, 2021 07:14
@hatoo
Copy link
Contributor Author

hatoo commented Aug 3, 2021

I've rebased and pushed.

@khyperia khyperia enabled auto-merge (squash) August 3, 2021 07:22
@khyperia khyperia merged commit d77cc6d into EmbarkStudios:main Aug 3, 2021
@hatoo hatoo deleted the fix-validation-error-ash-pr branch August 4, 2021 02:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants