This are some enhance feature for erpc multi-processor. #1

hakehuang · 2016-09-09T11:35:19Z

move the common code out to erpc_setup.h
when the salve spi is destroyed, we need make the master able to finish the transmission, otherwise the master will be in deadloop if slave is destroyed unexpectedly
add porting for mqx, just for information. for porting to any RTOS,
the transport need rewrite and the porting folder files need to be take care

Signed-off-by: Hake Huang <hake.huang@nxp.com>

flit · 2016-09-12T21:56:39Z

Hi @hakehuang, thanks for the PR. Will review shortly.

Hadatko · 2016-09-13T06:20:29Z

erpc_c/setup/erpc_server_setup.cpp

 #include "simple_server.h"
 #include "manually_constructed.h"
 #include "basic_codec.h"
 #include "message_buffer.h"


#include "message_buffer.h" and #include "erpc_config_internal.h" should be moved to erpc_setup.h

right, updated at 142ecdb

Signed-off-by: Hake Huang <hake.huang@nxp.com>

Hadatko · 2016-09-15T06:18:19Z

erpc_c/setup/erpc_setup.h

+        }
+    }
+};
+


Based on these changes this code "static ManuallyConstructed s_msgFactory;" and "
static ManuallyConstructed s_codecFactory;" from client/server setup files should be moved here too.
This header file #include "message_buffer.h" from client/server setup files should be removed.

move the static variable from server and client to a common place will have problem when you application have both server and client functions. e.g. in my test application, I use a run time command to switch between client and server, which make the static variable remains for server/client is better.

OK i didn't realized it. Is this switching client and server requested in your application? eRPC has appi for using client and server both in one application. It is covered by files containg word "arbitrator". Unfortunately we hadn't enough time for creating application with using this feature. But if you want i can send you more information about it. I am also working on documentation improvements where this feature is described.

yes, please.

Signed-off-by: Hake Huang <hake.huang@nxp.com>

Hadatko · 2016-09-15T17:33:05Z

erpc_c/transports/dspi_slave_transport.h

    SPI_Type *m_spiBaseAddr; /*!< Base address of DSPI peripheral used in this transport layer */
    uint32_t m_baudRate;       /*!< Baud rate of DSPI peripheral used in this transport layer */
    uint32_t m_srcClock_Hz;    /*!< Source clock of DSPI peripheral used in this transport layer */
+    bool m_binited;


Missing comment

right, commit 3174e60

Signed-off-by: Hake Huang <hake.huang@nxp.com>

This reverts commit 8c14710.

flit

Just a few minor changes requested to match coding style. Otherwise LGTM! Thanks for your PR.

Note that we'll probably be reworking the message buffer factory stuff for the setup API shortly. Probably will pass in a message buffer factory instance pointer similar to how the transport is passed in. The use case is for supporting the RPMsg-specific message buffer factories that enable zero-copy.

flit · 2016-09-19T19:08:16Z

erpc_c/transports/dspi_slave_transport.cpp


 DspiSlaveTransport::~DspiSlaveTransport()
 {
+    if(m_binited)


Please add a space between the "if" and "(" to match our coding style (same coding style as KSDK).

flit · 2016-09-19T19:09:01Z

erpc_c/transports/dspi_slave_transport.h

    SPI_Type *m_spiBaseAddr; /*!< Base address of DSPI peripheral used in this transport layer */
    uint32_t m_baudRate;       /*!< Baud rate of DSPI peripheral used in this transport layer */
    uint32_t m_srcClock_Hz;    /*!< Source clock of DSPI peripheral used in this transport layer */
+    bool m_binited;           /*!< the SPI peripheral init status flag */


Rename m_binited to m_isInited. We don't use type prefixes on names.

flit · 2016-09-19T19:11:15Z

erpc_c/setup/erpc_setup.h

+using namespace erpc;
+
+////////////////////////////////////////////////////////////////////////////////
+// CLASS


Change "CLASS" to mixed case "Classes".

flit · 2016-09-19T19:11:44Z

erpc_c/setup/erpc_setup.h

+
+#ifndef _EMBEDDED_RPC_SETUP_H_
+#define _EMBEDDED_RPC_SETUP_H_
+#include <new>


Insert blank line between #define and first #include.

Signed-off-by: Hake Huang <hake.huang@nxp.com>

flit · 2016-09-23T20:54:30Z

Thanks! LGTM.

…length This was spotted on a SAML21 controller: #0 usart_sync_read (io_descr=0x200006dc <USART_0>, buf=0x20000378 <s_msgFactory+8> , length=0) at ../hal/src/hal_usart_sync.c:271 EmbeddedRPC#1 0x000001e0 in io_read (io_descr=0x200006dc <USART_0>, buf=0x20000378 <s_msgFactory+8> , length=0) at ../hal/src/hal_io.c:62 EmbeddedRPC#2 0x0000e3da in erpc::UsartSyncTransport::underlyingReceive (this=0x20000578 <s_transport>, data=0x20000378 <s_msgFactory+8> , size=0) at ../erpc_usart_sync_transport.cpp:29 EmbeddedRPC#3 0x0000dd96 in erpc::FramedTransport::receive (this=0x20000578 <s_transport>, message=0x200026c4) at ../erpc_framed_transport.cpp:63 EmbeddedRPC#4 0x0000d7da in erpc::SimpleServer::runInternalBegin (this=0x20000340 <s_server>, codec=0x200026c0, buff=..., msgType=@0x200026bf: 32, serviceId=@0x200026b8: 536880832, methodId=@0x200026b4: 536871784, sequence=@0x200026b0: 536871784) at ../erpc_simple_server.cpp:64 EmbeddedRPC#5 0x0000d72a in erpc::SimpleServer::runInternal (this=0x20000340 <s_server>) at ../erpc_simple_server.cpp:42 EmbeddedRPC#6 0x0000d99e in erpc::SimpleServer::poll (this=0x20000340 <s_server>) at ../erpc_simple_server.cpp:223 EmbeddedRPC#7 0x0000d44e in erpc_server_poll () at ../erpc_server_setup.cpp:97 EmbeddedRPC#8 0x00006fa4 in main () at ../main.c:72 The UART need to be restarted to recover from a such error, for ex.: if (erpc_server_poll()) { usart_sync_disable(&USART_0); usart_sync_enable(&USART_0); }

- add west, gcc-arm-none-eabi, mcux-sdk repo

hakehuang added 3 commits September 9, 2016 19:29

move the common code to a separated file

de88568

Signed-off-by: Hake Huang <hake.huang@nxp.com>

clear the slave gpio to amek the master finish transfer

3fdb12c

Signed-off-by: Hake Huang <hake.huang@nxp.com>

add mqx port

753134b

Signed-off-by: Hake Huang <hake.huang@nxp.com>

Hadatko reviewed Sep 13, 2016
View reviewed changes

complete the header includes

142ecdb

Signed-off-by: Hake Huang <hake.huang@nxp.com>

Hadatko reviewed Sep 15, 2016

View reviewed changes

hakehuang added 2 commits September 15, 2016 21:36

fix the control gpio status for spi

8c14710

Signed-off-by: Hake Huang <hake.huang@nxp.com>

complete the comments for header file

91e2a96

Signed-off-by: Hake Huang <hake.huang@nxp.com>

Hadatko reviewed Sep 15, 2016

View reviewed changes

hakehuang added 3 commits September 16, 2016 20:39

tidy the headers

fdbe5a0

Signed-off-by: Hake Huang <hake.huang@nxp.com>

add comments for m_binited

3174e60

Signed-off-by: Hake Huang <hake.huang@nxp.com>

Revert "fix the control gpio status for spi"

e417366

This reverts commit 8c14710.

flit suggested changes Sep 19, 2016

View reviewed changes

tidy the coding styles

44ece25

Signed-off-by: Hake Huang <hake.huang@nxp.com>

flit approved these changes Sep 23, 2016

View reviewed changes

flit merged commit 108652a into EmbeddedRPC:master Sep 24, 2016

jcdr mentioned this pull request Oct 9, 2020

erpc_framed_transport.cpp: return error if received message has zero length #141

Merged

MichalPrincNXP added a commit that referenced this pull request Feb 1, 2022

Travis update testing #1

b02b6f1

MichalPrincNXP added a commit that referenced this pull request Feb 1, 2022

CircleCI update testing #1

f756c0a

- add west, gcc-arm-none-eabi, mcux-sdk repo

MichalPrincNXP added a commit that referenced this pull request Jul 27, 2022

Travis MAC update testing #1

3552e05

This are some enhance feature for erpc multi-processor. #1

This are some enhance feature for erpc multi-processor. #1

Uh oh!

Conversation

hakehuang commented Sep 9, 2016

Uh oh!

flit commented Sep 12, 2016

Uh oh!

Hadatko Sep 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hadatko Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hakehuang Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flit commented Sep 23, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Hadatko Sep 13, 2016 •

edited

Loading

Hadatko Sep 15, 2016 •

edited

Loading

hakehuang Sep 15, 2016 •

edited

Loading