Disable free-nonheap-object warnings #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without disabling this warning, g++ 11.1.0 emits this warning:
/project/erpc/Debug/Linux/erpcsniffer/obj/erpcgen_parser.tab.cpp: In function ‘int yyparse(erpcgen::ErpcLexer*, erpcgen::AstNode**)’:
/project/erpc/Debug/Linux/erpcsniffer/obj/erpcgen_parser.tab.cpp:3810:18: error: ‘void free(void*)’ called on unallocated object ‘yyssa’ [-Werror=free-nonheap-object]
3810 | YYSTACK_FREE (yyss);
/project/erpc/Debug/Linux/erpcsniffer/obj/erpcgen_parser.tab.cpp:2025:16: note: declared here
2025 | yy_state_t yyssa[YYINITDEPTH];
| ^~~~~
cc1plus: all warnings being treated as errors
Since -Werror is also enabled, this prevents erpcsniffer from building.
Background on false positives relating to this warning:
https://www.mail-archive.com/help-bison@gnu.org/msg04296.html
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98753
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54202
Member
|
Hello @dpfrey , thank you for trying the build in g++ 11.1.0 and providing this PR. Because the internal testing for the v1.8.1 release is almost finished, I would rather integrate this PR after the release, i.e. in about 3w. Thank you. |
MichalPrincNXP
approved these changes
Jun 24, 2021
Member
|
Thanks a lot for this PR! |
Member
|
Well, this PR causes CLANG build troubles, see https://app.travis-ci.com/github/EmbeddedRPC/erpc/builds/233096082 @dpfrey , may I ask you to have a look and solve (I have not run the Travis check before the PR integration), please? Thank you. |
Member
|
resolved within #233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without disabling this warning, g++ 11.1.0 emits this warning:
/project/erpc/Debug/Linux/erpcsniffer/obj/erpcgen_parser.tab.cpp: In function ‘int yyparse(erpcgen::ErpcLexer*, erpcgen::AstNode**)’:
/project/erpc/Debug/Linux/erpcsniffer/obj/erpcgen_parser.tab.cpp:3810:18: error: ‘void free(void*)’ called on unallocated object ‘yyssa’ [-Werror=free-nonheap-object]
3810 | YYSTACK_FREE (yyss);
/project/erpc/Debug/Linux/erpcsniffer/obj/erpcgen_parser.tab.cpp:2025:16: note: declared here
2025 | yy_state_t yyssa[YYINITDEPTH];
| ^~~~~
cc1plus: all warnings being treated as errors
Since -Werror is also enabled, this prevents erpcsniffer from building.
Background on false positives relating to this warning:
https://www.mail-archive.com/help-bison@gnu.org/msg04296.html
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98753
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54202