Modified name for common types macro scope.

[Hadatko]

Signed-off-by: Cervenka Dusan cervenka@acrios.com

Pull request

Choose Correct

• bug
• feature

Describe the pull request

Description #336
Default change from ERPC_TYPE_DEFINITIONS to ERPC_TYPE_DEFINITIONS_erpcShim
Default with program name change from ERPC_TYPE_DEFINITIONS to ERPC_TYPE_DEFINITIONS_
Using annotation value for @scope_name change from ERPC_TYPE_DEFINITIONS to ERPC_TYPE_DEFINITIONS_

To Reproduce

See tests

Expected behavior

See tests

Screenshots

Desktop (please complete the following information):

• OS:
• eRPC Version:

Steps you didn't forgot to do

• I checked if other PR isn't solving this issue.
• I read Contribution details and did appropriate actions.
• PR code is tested.
• PR code is formatted.
• Allow edits from maintainers pull request option is set (recommended).

Additional context

[Diagano]

Not that its mattrers much but maybe convert to uppercase in the template use of the scope_name?
{$upper(scope_name)}

[Hadatko]

Yeah i was thinking about that and i wanted to let it on user. User can use upper case in his definition.
@MichalPrincNXP what do you think?

[Diagano]

Well two points about that:

1. User choice in that case will also impact file naming
2. Use of lower case as default also counters that in some sense.

[Hadatko]

Well make sense. But i need distuinguish between annotation value and program name and use upper case only when annotation was not used.

[Diagano]

Got it. As I mentioned, I lack the system wide view and impacts. Thank you!

[Hadatko]

@Diagano i decided to do it as you proposed. UpperCase. It is because the macro name is still with eRPC prefix and users shouldn't use it and be aware of its existention. Will see future requests :D

[Hadatko]

@MichalPrincNXP what do you think about this PR?

[MichalPrincNXP]

@MichalPrincNXP what do you think about this PR?

I agree with the approach. There are some build fails after the rebase however:

erpcgen/src/Generator.cpp:98:14: error: 'transform' is not a member of 'std'
   std::transform(scopeNameC.begin(), scopeNameC.end(), scopeNameC.begin(), ::toupper);

Probably, the #include "algorithm" will be needed.

[MichalPrincNXP]

Thank you.