-
Notifications
You must be signed in to change notification settings - Fork 245
Fixed rpmsg tty transport to work with serial transport #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed rpmsg tty transport to work with serial transport #373
Conversation
Ability to receive message in two buffers Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
|
@MichalPrincNXP This should be ready for merge. |
|
Just curious, why the casting to void of functions needed (for example the memcpy)? I know that doing it to variables is for 'dummy' readings them, but why reading their return code needed? |
|
Hi @amgross , for example when you have misra, it will complain that you don't check for return values (same like variable which is not used). This way you are informing compiler that you are doing it on purpose. |
|
I think this is ready. Can you review it @MichalPrincNXP ? |
MichalPrincNXP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be ok, but I am not able to try it on any example. Did you have a chance to try it in any erpc app?
|
Locally i did. But i had a bit different code than this. |
|
I see, ok, we can accept that. Thank you. |
Ability to receive message in two buffers
Pull request
Choose Correct
Describe the pull request
#372
To Reproduce
send message from serial side to rpmsg tty side.
Expected behavior
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context