-
Notifications
You must be signed in to change notification settings - Fork 245
Add deinit function for rpmsg tty transport. #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deinit function for rpmsg tty transport. #78
Conversation
19007f9 to
dbc27bc
Compare
|
@Hadatko, the order of deinitialization is not correct. It should be done in this order: |
|
What should be done when deinit failed in destructor? |
|
What about to issue a global error or just keep the s_initialized = 1? |
|
s_initialized to one seems good. And thanks for point me to missing call function |
|
Should be fine now. Please recheck. |
|
additional comments: |
|
a. Well it depends. rpmsg denit function looks common for master and remote. So for other eRPC RPMSG transport layers can be created also deinit functions which will be common for both master/remote. So in this context it make sense to keep it this way. |
|
Thank you, Dusan. |
Add deinit function for rpmsg tty transport. #78
Add deinit function for rpmsg tty transport. EmbeddedRPC#78
Add deinit function for rpmsg tty transport. EmbeddedRPC#78
Update idl to 0.1.3 and erpc to v1.14.2
This function adds deinit function for RPMSG LITE TTY transport. @MichalPrincNXP could you provide feedback please. Is it ok to deinitialize master/remote tty RPMSG instance like this?