Minor correction in resampling code

[WaelDLZ]

• the will_resample=1 followed by if will_resample looked weird to me (probably legacy code ?)
• When we resample we should update the values of self.agent_offsets map dirs and num envs.

The fact that we didn't update them isn't an issue because right now they are not accessed anywhere in the code, but then we should either remove these attributes of the Drive Class or either make ensure they contain the right values if someone wants to use them later.

[greptile-apps]

Greptile Overview

Greptile Summary

Cleaned up resample logic by removing redundant will_resample=1 conditional and ensured instance attributes (agent_offsets, map_ids, num_envs) are properly updated during resampling to maintain consistency with initialization behavior.

• Removed unnecessary will_resample = 1 followed by if will_resample: block (likely legacy code)
• Added attribute updates after binding.shared() call during resample to keep instance state synchronized
• De-indented resample code block for improved readability
• No behavioral changes to resample logic itself, only improved code maintainability

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The changes are purely cleanup and consistency improvements with no functional impact on the resample logic execution, and the attributes being updated are currently unused elsewhere in the codebase
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
pufferlib/ocean/drive/drive.py	5/5	Removed redundant will_resample variable and added proper attribute updates during resampling for consistency

Sequence Diagram

sequenceDiagram
    participant Step as step()
    participant Binding as binding module
    participant Drive as Drive instance

    Note over Step,Drive: Resample frequency condition met
    Step->>Step: Check tick % resample_frequency == 0
    Step->>Step: Reset tick = 0
    
    Step->>Binding: vec_close(c_envs)
    Note over Binding: Close existing environments
    
    Step->>Binding: shared(num_agents, num_maps, ...)
    Binding-->>Step: Return (agent_offsets, map_ids, num_envs)
    
    Note over Step,Drive: NEW: Update instance attributes
    Step->>Drive: self.agent_offsets = agent_offsets
    Step->>Drive: self.map_ids = map_ids
    Step->>Drive: self.num_envs = num_envs
    
    loop For each environment in num_envs
        Step->>Binding: env_init(observations, actions, ...)
        Binding-->>Step: Return env_id
        Step->>Step: Append env_id to env_ids list
    end
    
    Step->>Binding: vectorize(*env_ids)
    Binding-->>Step: Return new c_envs
    Step->>Drive: self.c_envs = new c_envs
    
    Step->>Binding: vec_reset(c_envs, seed)
    Step->>Drive: self.terminals[:] = 1
    
    Step-->>Step: Return (observations, rewards, terminals, truncations, info)

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[vcharraut]

Maybe leave a comment saying this part of the code resample the maps