Skip to content

Conversation

@vcharraut
Copy link
Collaborator

This PR adds ruff tool for formatting and linting, and also pre-commit to ensure the application of ruff in every PR

@eugenevinitsky
Copy link

Approved but can you add a pre-commit install to setup? Either here or in a different PR?

@vcharraut
Copy link
Collaborator Author

I'm not sure to understand what do you mean by pre-commit install, like something in the CI ?

@eugenevinitsky
Copy link

Like, when people set up the repo pre-commit should be installed into their env so that they can't avoid pre-commit checks

@vcharraut
Copy link
Collaborator Author

Ok I see, I think it requires scripts to actually force to install the pre-commit hooks for each user.

I can be done in another PR that could actually clean/handle the install process

@eugenevinitsky
Copy link

Yeah that sounds fine, I'm just noting we should do that or at the least add the pre-commit install to the README

@vcharraut vcharraut merged commit 932360c into Emerge-Lab:main Sep 9, 2025
12 checks passed
@vcharraut vcharraut deleted the dev/ruff branch September 10, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants