Add required 'operation' to inputs#23
Merged
Merged
Conversation
…lear specified fields.
Contributor
Author
|
This is a great library! Hope you find my contribution helpful. |
Owner
|
Hi, thanks for opening this, this is great ✅ I'd normally leave a review with comments, but my changes are so trivial that I'll just merge the PR and push them later, just to save some time 😅 @all-contributors please add @ben-v for their code contributions |
Owner
|
My bad, let's try it again |
Contributor
|
I've put up a pull request to add @ben-v! 🎉 |
Contributor
Author
|
Great!! Thank you! Again, this is a great library. |
Owner
|
@ben-v The changes have been published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'operation' type to inputs in order to more cleanly separate set field(s) and clear field(s) operations. Was trying to clear a single field by assigning an empty string to the 'values' input. But, the parsing of the values input (empty) string into an array would not work since it in effect was trying to interpret an empty string and the logical evaluation "if (inputs.values)" to see if setting/clearing field(s) would equate to false. By adding an operation to the inputs, explicitly state what the operation is, i.e. "get" values for the specified field(s), "set" the specified field(s) to the specified value(s) or "clear" the specified field(s).