Skip to content

Add required 'operation' to inputs#23

Merged
EndBug merged 13 commits into
EndBug:mainfrom
teqbench:main
Oct 10, 2023
Merged

Add required 'operation' to inputs#23
EndBug merged 13 commits into
EndBug:mainfrom
teqbench:main

Conversation

@ben-v
Copy link
Copy Markdown
Contributor

@ben-v ben-v commented Oct 8, 2023

Added 'operation' type to inputs in order to more cleanly separate set field(s) and clear field(s) operations. Was trying to clear a single field by assigning an empty string to the 'values' input. But, the parsing of the values input (empty) string into an array would not work since it in effect was trying to interpret an empty string and the logical evaluation "if (inputs.values)" to see if setting/clearing field(s) would equate to false. By adding an operation to the inputs, explicitly state what the operation is, i.e. "get" values for the specified field(s), "set" the specified field(s) to the specified value(s) or "clear" the specified field(s).

@ben-v
Copy link
Copy Markdown
Contributor Author

ben-v commented Oct 8, 2023

This is a great library! Hope you find my contribution helpful.

@EndBug
Copy link
Copy Markdown
Owner

EndBug commented Oct 10, 2023

Hi, thanks for opening this, this is great ✅

I'd normally leave a review with comments, but my changes are so trivial that I'll just merge the PR and push them later, just to save some time 😅

@all-contributors please add @ben-v for their code contributions

@EndBug EndBug merged commit c047af6 into EndBug:main Oct 10, 2023
@EndBug
Copy link
Copy Markdown
Owner

EndBug commented Oct 10, 2023

My bad, let's try it again
@all-contributors please add @ben-v for their code contributions

@allcontributors
Copy link
Copy Markdown
Contributor

@EndBug

I've put up a pull request to add @ben-v! 🎉

@ben-v
Copy link
Copy Markdown
Contributor Author

ben-v commented Oct 10, 2023

Great!! Thank you! Again, this is a great library.

@EndBug
Copy link
Copy Markdown
Owner

EndBug commented Oct 11, 2023

@ben-v The changes have been published in v2.0.0 (also v2 and latest)
Thanks again for the PR ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants